Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Replace type with interface, document typescript theme customization #9350

Merged
merged 2 commits into from
Nov 30, 2017
Merged

[docs] Replace type with interface, document typescript theme customization #9350

merged 2 commits into from
Nov 30, 2017

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Nov 30, 2017 •
edited
Loading

  • where appropriate, replace type with interface allowing for augmentation
  • also removed any unused imports I bumped into
  • added section in typescript guide regarding customizing the theme with module augmentation

@rosskevin rosskevin requested a review from pelotom November 30, 2017 21:35
@mui mui deleted a comment from codecov bot Nov 30, 2017
@rosskevin rosskevin added the docs Improvements or additions to the documentation label Nov 30, 2017
@rosskevin rosskevin changed the title Review export type and replace with export interface where appropriate Replace type with interface, document typescript theme customization Nov 30, 2017
@pelotom pelotom merged commit dc3b2fd into mui:v1-beta Nov 30, 2017
@rosskevin rosskevin deleted the ts-type-to-interface branch November 30, 2017 23:04
@oliviertassinari oliviertassinari changed the title Replace type with interface, document typescript theme customization [docs] Replace type with interface, document typescript theme customization Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelotom pelotom Awaiting requested review from pelotom

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosskevin @pelotom